Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix high tech low life start #37479

Merged

Conversation

curstwist
Copy link
Contributor

@curstwist curstwist commented Jan 28, 2020

Summary

SUMMARY: Bugfixes "fixes High Tech/Low Life start from lacking a house."

Purpose of change

Fixes: Shady basement spawns without house upstairs #37455, until the basements can be fully overhauled.

Describe the solution

I found a house to attach it to until we can make more randomized basements with explicit stair placement.

I took this basement off the no_rotate flag so it can rotate with its house. I didn't remove it from the general basement spawn chances so I'm not sure if there will be an impact for removing the flag. Stairs are pretty messed up right now anyway. EDIT: I removed the entry at ralreegorganon's suggestion.

Describe alternatives you've considered

Eventually I'd rather this be a nested chunk that can appear rarely and more randomly.

Testing

Tried the scenario start in world, checked stair alignment, was pleased I was in a house.

Additional context

This has brought up additional issues that are better resolved post 0.E release. This is more a temporary fix then a proper resolution to the issue.

@Rivet-the-Zombie Rivet-the-Zombie merged commit 5200e8b into CleverRaven:master Jan 29, 2020
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jan 29, 2020
@eilaattwood
Copy link
Contributor

The game crashed for me with error on bionic basement terrain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants