Fix external options messing with world options #37155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fix external options messing with world options.
Fixes #37138
Describe the solution
Put external options to a different page from world options.
Testing
options.json
from previous (broken) version and see that game starts successfully with the fix applied, no options appear on world settings page in options menu.FILTHY_CLOTHES
option in\data\json\game_balance.json
and see that filthy clothes appear depending on value of the option).Additional context
We will need a more robust solution for external options probably, but this should be good hotfix for now.