Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds new options to allow auto ignoring sounds and hostile creatures based on safe mode #35983

Closed
wants to merge 15 commits into from

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Dec 9, 2019

Summary

SUMMARY: Interface "Adds new options to allow auto ignoring sounds and hostile creatures."

Purpose of change

Fixes #28672
Fixes #36151
Expanded and reworked version of #35436
Adds new options to allow auto ignoring based on safe mode and distance.

Describe the solution

Added new settings. Auto ignore sound/hostile mode can be set to ignore always, never or when safe
mode is on or off. There is a distance setting so you can choose to only ignore sounds or creatures past a specific distance away. No matter what settings are chosen dangerously close monster warnings will still appear as will creatures coming out of portals

Describe alternatives you've considered

Various other combos of settings. A separate distance setting for safe mode on vs. off

Testing

Additional context

@Ramza13 Ramza13 changed the title Adds new options to allow auto ignoring sounds and hostile creatures Adds new options to allow auto ignoring sounds and hostile creatures based on safe mode Dec 9, 2019
@ave-
Copy link

ave- commented Dec 9, 2019

Is z-level taken into account? I do not want to be warned about a sound 5 z-levels below me if I have a setting to warn about sound in 5-tile radius. There should be either a separate setting for z-level or different z-level sounds should be ignored entirely.

@Ramza13
Copy link
Contributor Author

Ramza13 commented Dec 9, 2019

Is z-level taken into account? I do not want to be warned about a sound 5 z-levels below me if I have a setting to warn about sound in 5-tile radius. There should be either a separate setting for z-level or different z-level sounds should be ignored entirely.

Presently z levels are counted in the distance. However each z level counts as 10 squares so in your 5 square example all sounds on different z levels would be ignored.

src/options.cpp Outdated Show resolved Hide resolved
src/options.cpp Outdated Show resolved Hide resolved
src/options.cpp Outdated Show resolved Hide resolved
src/options.cpp Outdated Show resolved Hide resolved
Ramza13 and others added 4 commits December 10, 2019 07:39
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
@curstwist curstwist added [C++] Changes (can be) made in C++. Previously named `Code` SDL: Tiles / Sound Tiles visual interface and sounds. Mechanics: Character / Player Character / Player mechanics and removed SDL: Tiles / Sound Tiles visual interface and sounds. labels Dec 10, 2019
@Ramza13
Copy link
Contributor Author

Ramza13 commented Dec 11, 2019

Added in an option to allow auto ignoring of sounds on different z levels regardless of distance

@kevingranade
Copy link
Member

This adds way too many new options, we already have too many, and we need really strong justification for new ones.

@Ramza13
Copy link
Contributor Author

Ramza13 commented Dec 22, 2019

This adds way too many new options, we already have too many, and we need really strong justification for new ones.

Ok fair enough. If I just made it two options one for when to auto-ignore sounds/hostiles and a second for distance would that be better or would you prefer a non option based solution?

@Ramza13
Copy link
Contributor Author

Ramza13 commented Dec 23, 2019

Trimmed this back to 2 options. Now there is a single setting for auto ignoring both sounds and hostiles and a single distance. Ignoring z levels is also gone but each one is 10 horizontal distance so its not so bad.

src/options.cpp Outdated Show resolved Hide resolved
src/options.cpp Outdated Show resolved Hide resolved
@Ramza13 Ramza13 changed the title Adds new options to allow auto ignoring sounds and hostile creatures based on safe mode [WIP] Adds new options to allow auto ignoring sounds and hostile creatures based on safe mode Jan 5, 2020
@Ramza13 Ramza13 closed this Jan 5, 2020
@Ramza13 Ramza13 deleted the ignore_options branch November 17, 2021 17:00
@CleverRaven CleverRaven deleted a comment from Balgias Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics
Projects
None yet
6 participants