-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adds new options to allow auto ignoring sounds and hostile creatures based on safe mode #35983
Conversation
Is z-level taken into account? I do not want to be warned about a sound 5 z-levels below me if I have a setting to warn about sound in 5-tile radius. There should be either a separate setting for z-level or different z-level sounds should be ignored entirely. |
Presently z levels are counted in the distance. However each z level counts as 10 squares so in your 5 square example all sounds on different z levels would be ignored. |
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Co-Authored-By: Anton Burmistrov <[email protected]>
Added in an option to allow auto ignoring of sounds on different z levels regardless of distance |
This adds way too many new options, we already have too many, and we need really strong justification for new ones. |
Ok fair enough. If I just made it two options one for when to auto-ignore sounds/hostiles and a second for distance would that be better or would you prefer a non option based solution? |
Trimmed this back to 2 options. Now there is a single setting for auto ignoring both sounds and hostiles and a single distance. Ignoring z levels is also gone but each one is 10 horizontal distance so its not so bad. |
Co-Authored-By: Alexey Mostovoy <[email protected]>
Summary
SUMMARY: Interface "Adds new options to allow auto ignoring sounds and hostile creatures."
Purpose of change
Fixes #28672
Fixes #36151
Expanded and reworked version of #35436
Adds new options to allow auto ignoring based on safe mode and distance.
Describe the solution
Added new settings. Auto ignore sound/hostile mode can be set to ignore always, never or when safe
mode is on or off. There is a distance setting so you can choose to only ignore sounds or creatures past a specific distance away. No matter what settings are chosen dangerously close monster warnings will still appear as will creatures coming out of portals
Describe alternatives you've considered
Various other combos of settings. A separate distance setting for safe mode on vs. off
Testing
Additional context