Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change crossed_threshold() scope and test_crossing_threshold() parameter to Character #34761

Merged
merged 4 commits into from
Oct 16, 2019

Conversation

KorGgenT
Copy link
Member

Summary

SUMMARY: Infrastructure "Change scope of crossed_threshold() and changed parameter of test_crossing_threshold() to Character"

Purpose of change

part of #34721
additionally this should make it easier for me to encapsulate all the mutation stuff.

Describe the solution

see commit messages

Testing

Compiled Successfully.

@KorGgenT KorGgenT added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Oct 14, 2019
@ZhilkinSerg ZhilkinSerg merged commit 94104c6 into CleverRaven:master Oct 16, 2019
Ramza13 pushed a commit to Ramza13/Cataclysm-DDA that referenced this pull request Oct 22, 2019
…ter to Character (CleverRaven#34761)

* change scope of crossed_threshold()

* moved crossed_threshold to character.cpp

* change parameter of test_crossing_threshold to Character

* change "p" to "guy"
@KorGgenT KorGgenT deleted the crossed-threshold-scope branch August 13, 2020 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants