Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect unused json members #34735

Merged
merged 8 commits into from
Oct 25, 2019
Merged

Detect unused json members #34735

merged 8 commits into from
Oct 25, 2019

Commits on Oct 24, 2019

  1. Remove some more useless json members

    @jbytheway
    jbytheway committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    d67e791 View commit details
    Browse the repository at this point in the history

  2. Fix some minor errors in json data

    @jbytheway
    jbytheway committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    267c803 View commit details
    Browse the repository at this point in the history

  3. Remove "chance" from "place_npcs"

    @jbytheway
    jbytheway committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    566033f View commit details
    Browse the repository at this point in the history

  4. Add JsonObject member sanity checking 

    Verify when we destroy a JsonObject that we actually visited all the
fields of that object.  If we didn't, this suggests an error of some
kind in the input data.

Default is to report an error to the debug log, which users won't
notice, but will cause a test failure in CI.

This means we need to nearly always pass JsonObjects by non-const
reference, so that all the member visitations get registered in a single
place.

One can opt out of this check by calling allow_omitted_members on the
JsonObject.  We need to add such calls in a bunch of places that don't
visit all the members for one reason or another.

Also added various other tweaks and workarounds to prevent false error
report.

The checking has to not be turned on when building the json tooling
executables, because it leads to linking errors (the debug log doesn't
exist for them).
    @jbytheway
    jbytheway committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    95bf9c0 View commit details
    Browse the repository at this point in the history

  5. Document the new JsonObject behaviour

    @jbytheway
    jbytheway committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    ee30fe0 View commit details
    Browse the repository at this point in the history

  6. Fix more json errors 

    These are a collection of new json fixes newly required since I first
made this PR.
    @jbytheway
    jbytheway committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    fda4ef1 View commit details
    Browse the repository at this point in the history

  7. Reinstate blueprint_requires members (commented) 

    In response to discussion on
CleverRaven#34735
    @jbytheway
    jbytheway committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    efa5270 View commit details
    Browse the repository at this point in the history

  8. Fix more Magiclysm json errors

    @jbytheway
    jbytheway committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    0ec0c52 View commit details
    Browse the repository at this point in the history