Changelog thru october #34731
Merged
Changelog thru october #34731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Documentation>
ZhilkinSerg
reviewed
Oct 14, 2019
ZhilkinSerg
reviewed
Oct 14, 2019
ZhilkinSerg
reviewed
Oct 14, 2019
ZhilkinSerg
reviewed
Oct 14, 2019
ZhilkinSerg
reviewed
Oct 14, 2019
ZhilkinSerg
reviewed
Oct 14, 2019
ZhilkinSerg
reviewed
Oct 14, 2019
ZhilkinSerg
reviewed
Oct 14, 2019
ZhilkinSerg
reviewed
Oct 14, 2019
|
It's beautiful... |
Add some periods. Co-Authored-By: ZhilkinSerg <[email protected]>
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Oct 22, 2019
* Revert "July and August changelogs (CleverRaven#34095)" This reverts commit 7a20bb6. * Have changelog generation script consider unmerged PRs too * Import changelog entries through 10-09 * Copyedit changelog * Apply suggestions from code review Add some periods. Co-Authored-By: ZhilkinSerg <[email protected]>
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Nov 5, 2019
* Revert "July and August changelogs (CleverRaven#34095)" This reverts commit 7a20bb6. * Have changelog generation script consider unmerged PRs too * Import changelog entries through 10-09 * Copyedit changelog * Apply suggestions from code review Add some periods. Co-Authored-By: ZhilkinSerg <[email protected]>
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Nov 5, 2019
* Revert "July and August changelogs (CleverRaven#34095)" This reverts commit 7a20bb6. * Have changelog generation script consider unmerged PRs too * Import changelog entries through 10-09 * Copyedit changelog * Apply suggestions from code review Add some periods. Co-Authored-By: ZhilkinSerg <[email protected]>
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Nov 5, 2019
* Revert "July and August changelogs (CleverRaven#34095)" This reverts commit 7a20bb6. * Have changelog generation script consider unmerged PRs too * Import changelog entries through 10-09 * Copyedit changelog * Apply suggestions from code review Add some periods. Co-Authored-By: ZhilkinSerg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Logs for the change god!
Turns out there was an issue where a certain configuration of PRs would make the changelog generation script give up early and not match PRs to commits.
Describe the solution
Make the changelog generation script not prune un-merged PRs out of it's fetch routine. This means the script fetches more stuff, but insure it gets everything it needs.
Reverted the previously comitted July and August changelogs because some of them were tainted by this bug.
Then the usual import followed by copyediting.