Fix furniture door pathfinding #34720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "NPCs now properly open furniture doors"Purpose of change
Fixes #34646 - NPCs unable to open tent flaps
Describe the solution
Modified pathfinding to consider tiles with openable furniture. Also added a check to NPC movement so they won't phase through doors, and instead try to open them.
Testing
Closed door in front of friendly npcs to see if the opened it properly (Tried with both furniture and terrain doors).
Closed door in front of zed to see if they tried to find their way through to me.
Additional context
The canvas flap was the only furniture door with impassable properties (f_canvas_door and f_large_canvas_door). Apart from this, the only doors are: f_counter_gate_c and f_beaded_door. Should the also be impassable? Or should the canvas flap not be impassable. Either way, npcs now properly open them regardless, but I'm not sure how this plays with the pathfinding of monsters.