Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 4 more nested house foundations #34692

Merged

Conversation

curstwist
Copy link
Contributor

Summary

SUMMARY: Content "Adds 4 new house foundations for nested chunks"

Purpose of change

Add more housing variety.

Describe the solution

Adds 4 more single story foundations for the nested chunks.
This is dependent on: Add nested houses 1 #34691 being merged.

Describe alternatives you've considered

see previous PR.

Testing

I've spawned a test area in a world with my houses and toured them looking for poorly placed nests. There may be some I'll need to winnow out as they are encountered. It's difficult to account for all permutations.

I also toured a size 16 city to look at their spawn rates and placement. I'm pretty happy with their representation. I lowered duplexes and prepper houses which were slightly too common.

Additional context

House 2:
image

House 3:
image

House 4:
image

House 5: (no cars spawning yet)
image

@Destragon
Copy link

Destragon commented Oct 13, 2019

Do these houses have any bathroom item spawns like softdrugs and harddrugs?

Edit:
I see the bathroom item spawns are in house_w_palette.json in the other pull request. 10% chance for softdrugs sounds really low though. Most houses have 75% for softdrugs as well as 15% for harddrugs.

@curstwist
Copy link
Contributor Author

Do these houses have any bathroom item spawns like softdrugs and harddrugs?

Edit:
I see the bathroom item spawns are in house_w_palette.json in the other pull request. 10% chance for softdrugs sounds really low though. Most houses have 75% for softdrugs as well as 15% for harddrugs.

I've adjusted them some, I added cleaning and hard drugs to the list and upped softdrug spawns.
Using x,y coordinates vs. explicit placement via a symbol tends to result in different spawn levels, so I didn't use your suggested percentages. They are reasonably generous now, with 2-5 items spawning in the sinks. These item_groups will be swapped out for an SUS style item_group when I get to that part.

@ZhilkinSerg ZhilkinSerg added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Oct 13, 2019
@ZhilkinSerg ZhilkinSerg merged commit 610f898 into CleverRaven:master Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants