Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide blacksmith survey #34661

Merged
merged 2 commits into from
Oct 12, 2019

Conversation

curstwist
Copy link
Contributor

@curstwist curstwist commented Oct 11, 2019

Summary

SUMMARY: Bugfixes "Fix Blacksmith Survey option appearing on bulletin board."

Purpose of change

revert the changes to recipe_primitive_field.json that were made in ##34455. This removed the "blueprint_requires": [ { "id": "not_an_upgrade" } ], entry from the blacksmith survey and fortification walls.

Describe the solution

mlangsdorf caught its absence during review.

Describe alternatives you've considered

Testing

Loaded up a game and built a camp. Made sure the survey wasn't an option anymore. I also checked after completing a survey expansion mission.

Additional context

gone from menu:
image

Copy link
Contributor

@mlangsdorf mlangsdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks much

@mlangsdorf mlangsdorf added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Player Faction Base / Camp All about the player faction base/camp/site labels Oct 11, 2019
@ZhilkinSerg ZhilkinSerg merged commit c86bc99 into CleverRaven:master Oct 12, 2019
@curstwist curstwist deleted the hide-blacksmithy-survey branch October 12, 2019 11:48
@jbytheway
Copy link
Contributor

I agree the blueprint_requires is needed for faction_base_blacksmith_0. Guess I deleted that one by accident in #34455; sorry about that.

However, I stand by the other changes. blueprint_requires shouldn't be there in faction_wall_level_N_0 or faction_wall_level_N_1 because blueprint_requires doesn't do anything unless construction_blueprint is present. Should those other entries have a construction_blueprint field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Player Faction Base / Camp All about the player faction base/camp/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants