Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hit_you_effect and hit_me_effect #34631

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Conversation

KorGgenT
Copy link
Member

Summary

SUMMARY: Features "Added hit_you_effect and hit_me_effect fields to enchantments"

Purpose of change

part of the artifact project, expands versatility of enchantments

Describe the solution

Adds functions that cast all the spell effects attributed when you are hit by a creature ("hit_me_effect" in json) or when you hit a creature ("hit_you_effect" in json)
I added a debug item "debug_fireball_hammer" in order to showcase the functionality; you'll cast a fireball when you hit something, and you'll cast cure light wounds when you get hit by something.

Additional context

fireball hammer

@KorGgenT KorGgenT added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Artifacts Otherworldly items with special effects labels Oct 11, 2019
@KorGgenT KorGgenT marked this pull request as ready for review October 11, 2019 02:45
@foulman
Copy link
Contributor

foulman commented Oct 11, 2019

Will this interact with USE_PLAYER_ENERGY? Charges?

@KorGgenT
Copy link
Member Author

not as coded

@kevingranade kevingranade merged commit 7fcaf47 into CleverRaven:master Oct 11, 2019
@KorGgenT KorGgenT deleted the hit-effects branch October 12, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Artifacts Otherworldly items with special effects [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants