Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved bluebell flower to obsolete #34569

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Moved bluebell flower to obsolete #34569

merged 1 commit into from
Oct 8, 2019

Conversation

snipercup
Copy link
Contributor

Summary

SUMMARY: Content "Move bluebell_flower to obsolete"

Purpose of change

Was sitting in /items/generic.json and nothing except for 2 tilesets were referring to it.

Describe the solution

Moved to obsolete

Describe alternatives you've considered

Finding a use for it, but #14961 states that bluebell flowers are useless and they were removed from spawn.

Additional context

Found it using my json analyser

The game still allows you to spawn it using debug
image

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Oct 8, 2019
@ZhilkinSerg ZhilkinSerg merged commit cb7b4b0 into CleverRaven:master Oct 8, 2019
@snipercup snipercup deleted the move-bluebell-flower-to-obsolete-json branch October 9, 2019 13:14
@jbytheway
Copy link
Contributor

It sounds like you have a json analyser that can detect items which are not referenced (and perhaps other issues). I was thinking that we should have such a check in the CI tests. Are you planning to add it once the errors it finds are resolved?

@snipercup
Copy link
Contributor Author

I lack the skill to add it. I can do Javascript but not C++ (yet). It's a resource heavy algorithm so if it were to be added, it should be written efficiently. I already fixed the most obvious items that were not referenced. I think it's good to run it from time to time. Balancing item weight is a bigger challenge though.

@AMurkin
Copy link
Contributor

AMurkin commented Nov 19, 2019

@snipercup
Copy link
Contributor Author

snipercup commented Nov 19, 2019

Thanks for the suggestion. I may visit it at a later time. I'm working on other stuff atm. I recall it took 10 minutes to analyse the existence of every vanilla item (mods not counted). In the meantime anyone can look at my repo and find the item existence analyser and its code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants