Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new mission/talk effect u_learn_recipe #33574

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

ralreegorganon
Copy link
Contributor

Summary

SUMMARY: Features "Add new mission/talk effect u_learn_recipe"

Purpose of change

This adds a new effect for usage in dialogues and missions, u_learn_recipe which will teach the player the specified recipe. It also has a counterpart condition to check whether a recipe is memorized, u_know_recipe.

Describe the solution

I followed the existing patterns for effects and condition here. The only special things to note are that a recipe is only considered known by the condition if it's memorized--having a book with the recipe on hand is insufficient, and the recipe may be learned even if the player has insufficient skill to execute it.

I also added a demonstration mission that uses this feature, where the player is asked to fetch cattail stalks and is then taught how to make cattail jelly. It's not really the focus of these changes--I just wanted to have something exercising the functionality and I feel like we can always use more missions.

@ralreegorganon ralreegorganon added <Enhancement / Feature> New features, or enhancements on existing <Documentation> Design documents, internal info, guides and help. NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Missions Quests and missions [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs labels Aug 26, 2019
@ZhilkinSerg ZhilkinSerg merged commit d0d3619 into CleverRaven:master Aug 27, 2019
misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
* Add u_learn_recipe effect and u_know_recipe condition

* Add new mission MISSION_LEARN_ABOUT_CATTAIL_JELLY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants