clang-tidy bugprone-use-after-move #33557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable this clang-tidy check and deal with associated warnings. Mostly these were suppressions for things in the tests that are specifically testing move constructor semantics, but one case was a genuine latent bug.
This error seems to have crept into master.
ZhilkinSerg
added
[C++]
misterprimus
pushed a commit
to misterprimus/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2019
* Enable bugprone-use-after-move Enable this clang-tidy check and deal with associated warnings. Mostly these were suppressions for things in the tests that are specifically testing move constructor semantics, but one case was a genuine latent bug. * Fix mismatched declaration name This error seems to have crept into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
More static analysis.
This check looks for uses of objects after they have been moved from.
Describe the solution
Enable the
clang-tidycheckbugprone-use-after-moveand fix related issues.Most were suppressions of things in the tests that were deliberately testing move constructor semantics.
One was a genuine (latent) bug.
Also fixed a
readability-inconsistent-declaration-parameter-namethat has snuck onto master.Describe alternatives you've considered
Could have just removed the
std::movein the one buggy case. I don't think it's actually being moved in any case.Additional context
36 more checks to triage after this.