Fix #33486 'All furniture storage became 1000L' by reverting furniture max_volume #33534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
misterprimus
pushed a commit
to misterprimus/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2019
…ng furniture max_volume (CleverRaven#33534) * revert furniture max_volume to int units * revert furniture max_volume to int units in furniture.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix #33486 'All furniture storage became 1000L' by reverting furniture max_volume"Purpose of change
Fixes #33486 which was caused by #33367.
Apparently furniture and terrain
max_volumecan't handle metric units so they all default to 1000L.Describe the solution
Revert change in furniture to integer units of 250ml.
Describe alternatives you've considered
It would be better to make furniture and terrain handle metric units for
max_volume.Additional context
This is intended as an optional temporary fix until furniture and terrain can handle metric units.
Close this if that's done.