Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to the photo description #33530

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Aug 25, 2019

Summary

SUMMARY: Bugfixes "Fix some issues in the composition of photo descriptions"

Purpose of change

Fix some translation updating issue and format issues in the generation of photo descriptions. Especially the choice of singular or plural syntaxes.

Describe the solution

  1. Changed the place some strings are translated so the correct language is used when composing the descriptions.
  2. Changed "in %s cloud" to "in %s" to avoid duplicate terms such as "hazy cloud cloud".
  3. Fixed article being added to description of multiple items ("a 2 chairs")
  4. Do not remove space unless there is actually a space. (Important because in Chinese the period+space is translated to the Chinese period without space, which is also a multi-byte character. Removing the last byte in this case would leave the text broken).
  5. Actually count the number of described items instead of the number of terms describing the items, to select the correct singular or plural syntaxes.
  6. Fixed an untranslated "You".

Additional context

This is just me ranting, but the way the text is composed in these code is giving me nightmares trying to translate them to Chinese without producing some utter nonsense... How am I supposed to cram all these clauses into one sentence in Chinese? (I ended up replacing all of these clauses with ’and blah blah'. At least it made some sense.)

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Translation I18n labels Aug 25, 2019
@ZhilkinSerg ZhilkinSerg merged commit 50eb071 into CleverRaven:master Aug 25, 2019
@Qrox Qrox deleted the fix-photo-desc branch August 29, 2019 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants