Make Sweet Tooth a starting trait #33477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed ANTIJUNK from possible starting traits, created a new trait group with both PROJUNK and ANTIJUNK and added that group to possible starting traits. Possibility 5 because of allergy.
alkemann
added
Mutations / Traits / Professions/ Hobbies
misterprimus
pushed a commit
to misterprimus/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2019
* Changed Sweet Tooth to be a starting trait * Added Sweet Tooth starting trait to NPCs Removed ANTIJUNK from possible starting traits, created a new trait group with both PROJUNK and ANTIJUNK and added that group to possible starting traits. Possibility 5 because of allergy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Make 'Sweet Tooth' a starting trait"Purpose of change
Sweet Tooth seems trait-like and like a viable candidate for a starting trait. Its counterpart, Junkfood Intolerance, is already a starting trait, and while it is a realistic trait for a normal person to have, Sweet Tooth can currently only be obtained through mutations.
Describe the solution
Sweet Tooth has been changed to be a starting trait, and a new NPC trait group, "trait_group_PROJUNK", has been added to encompass Sweet Tooth and Junkfood Intolerance. It was given a probability of 5 due to the group containing an allergy. Junkfood Intolerance has been removed from the NPC starting traits.
Describe alternatives you've considered
If it is decided that Sweet Tooth stay mutation-only, it should be made clear that it is an unnatural attachment to junk food rather than a preference, like Sugar-Loving. If Sweet Tooth's morale bonus is too high, it could warrant the trait's cost being bumped up to 2, or having the morale bonus lowered.
Additional context
This is my first PR on GitHub, so please tell me if I've done anything wrong.