Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add survival kit #33428

Merged
merged 12 commits into from
Aug 24, 2019
Merged

Add survival kit #33428

merged 12 commits into from
Aug 24, 2019

Conversation

ampersand55
Copy link
Contributor

@ampersand55 ampersand55 commented Aug 21, 2019

Summary

SUMMARY: Content "Add survival kit

Purpose of change

Variety. The survival kit works similar to a first aid kit.

Describe the solution

Weight 1612 mg, the weight of the items.
Volume: 1 L, a bit less than the items contained as survival kits are usually packed to minimize volume.
Contents:

  • folding knife
  • flint and steel
  • whistle multitool
  • foldable plastic bottle
  • glowstick
  • 15 water purification tablets
  • flare gun + 8 signal flares 4 hand flares
  • survivor's map
  • pocket survival guide (new!)
  • survival kit box (1 L)

Added to item groups:

  • camping
  • traveler
  • mil_surplus
  • shelter
  • mil_accessories
  • helicopter
  • car_kit
  • survivorzed_extra
  • college_camping
  • dollar_tools

EDIT: Survivor zombie now also has a small chance of dropping a damaged survivor kit.
EDIT2: Implemented suggestions by @Maddremor.
EDIT3: Implemented suggestion by @Petethegoat.
EDIT4: Implemented suggestion by @ZhilkinSerg.

Describe alternatives you've considered

I've debated which items it should contain a lot, but I wanted to make it as light as possible.

Additional context

image

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Aug 21, 2019
@Maddremor
Copy link
Contributor

Maddremor commented Aug 21, 2019

Is it supposed to be a homemade kit or an of the shelf thing? The survivor's map is hand annotated, which is less fitting for a commercial product.

What kind of packaging does it come in? Anything usable for storing liquids, or even as tinder?

@ampersand55
Copy link
Contributor Author

I kind of imagined that it could be either or, but I suppose it wouldn't make sense to have something with an annotated map found in a military surplus store.

What kind of packaging does it come in? Anything usable for storing liquids, or even as tinder?

I suppose a container with boiling quality would make sense.

I'll incorporate these changes tomorrow and I'll mark this as a WIP/CR for now.

@ampersand55 ampersand55 changed the title Add survival kit [WIP][CR] Add survival kit Aug 21, 2019
@ampersand55 ampersand55 changed the title [WIP][CR] Add survival kit Add survival kit Aug 22, 2019
@Petethegoat
Copy link
Contributor

I would consider replacing the flaregun. I think one or two of those wire survival saws would be perfect, along with maybe a few other small goodies instead.

@ampersand55
Copy link
Contributor Author

I'm not sure about the flare gun myself, I went off and on with the handflare and the flare gun several times.

I really like the flare gun, but considering its price it might be a mismatch with the other items.

@ZhilkinSerg
Copy link
Contributor

Shouldn't it have some booklet inside too?

@ampersand55
Copy link
Contributor Author

Shouldn't it have some booklet inside too?

Good idea, added a "Pocket Survival Guide".

Or should I create a custom booklet like with first aid kit?

@ZhilkinSerg ZhilkinSerg merged commit e1e05ce into CleverRaven:master Aug 24, 2019
misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
* Add a survival kit

* add to item groups

* change description to not be written by Mario

* fix another spelling error

* give survivor zombie a small chance of dropping a survivor kit

* give survivor zombie a small chance of dropping a survival kit

* implemented suggestions by @Maddremor

* remove irrelevant flag

* handflares instead of flare gun

* add Pocket Survival Guide to kit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants