Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffs the Spiritual trait #28866

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Buffs the Spiritual trait #28866

merged 1 commit into from
Mar 21, 2019

Conversation

Ilysen
Copy link
Contributor

@Ilysen Ilysen commented Mar 21, 2019

Summary

SUMMARY: Balance "The Spiritual trait has received a significant buff."

Purpose of change

Spiritual is a bit of a weird trait. In its current state, it's almost a bad thing to take because of how many side interactions it has, what with making you revile so many things such as butchering humans, and soon, gravedigging. On top of that, Bookworm makes it nearly irrelevant, by adding +1 to the fun of all books.

Usually, it wouldn't be so bad, but every holy book only has 1 fun value anyway. Thus, the tripled fun value of holy books doesn't mean anything; they only give +3 fun, which is irrelevant when Bookworm gives most novels +4 or +5 -and- appears to nullify the rereading penalty.

Describe the solution

Rather than tripling the fun value of holy books, Spiritual now adds +1 to its fun value, then triples it. This means holy books will have a fun value of +6 instead of the +3 they currently have.

Describe alternatives you've considered

Making holy books more fun. Because each faith is represented equally in Cataclysm, it seemed like a silly idea to buff some without others, but bumping every holy book to +2 fun would accomplish the same buff equally.

Additional context

The highest possible fun value you can get from a book by combining Bookworm and Spiritual comes from Visions of Solitude, found only in prisons, with a base fun value of +2. Combined with the flat +1 increase of Bookworm and new Spiritual, the tripled number thus gives a fun value of +12. I thought that it made contextual sense, but I'm fine with putting a hard cap on the amount to, say, +8.

@KorGgenT KorGgenT added Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Mar 21, 2019
@ZhilkinSerg ZhilkinSerg merged commit 462722b into CleverRaven:master Mar 21, 2019
@Ilysen Ilysen deleted the SpiritualBuff branch March 21, 2019 15:35
@kevingranade
Copy link
Member

Spiritual doesnt need a buff, it already gives morale boosts from several sources for just one point. It's already much better than bookworm.

@Ilysen
Copy link
Contributor Author

Ilysen commented Mar 21, 2019

Like what? I haven't found them, even having played Spiritual characters. All I can find through GIt syntax search besides the holy books is hallucinogenic food and meditating - one of which only lasts two hours, and the other of which is a tiny boost. On the contrary, killing innocents(?), butchering humans, eating human flesh, and soon gravedigging all massively impact your morale much more with Spiritual. The lack of apparent upsides is why I made this PR.

Edit: I went and properly searched through all the code. Despite the different messages, Spiritual doesn't actually appear to further impact morale from cannibalism and butchery, but the only places that it gains a morale boost are from books and from hallucinogenic foods like datura. I personally think that Bookworm is much stronger and that this buff is fine, but if you disagree, I'm fine with discussing it.

@I-am-Erk
Copy link
Member

Wearing spiritual clothing also gives you a morale buff.

@Ilysen
Copy link
Contributor Author

Ilysen commented Mar 21, 2019

That doesn't appear to be the case. To make sure I wasn't going insane, I tested that on this PR's build with the following items:
image
image
But this didn't appear to affect my morale in any way.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants