player display: adds support for hidden traits #27432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the syntax highlighting to C++, since that produces more attractive results with the inline comments.
Add support for hidden traits that are not displayed in the '@' menu.
Hide the NPC only traits and the survivor story traits.
mlangsdorf
added
Info / User Interface
|
jenkins rebuild |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "player display: add support for hidden traits"Purpose of change
Part of addressing #27397
Add the ability for traits to not be displayed in the '@' player display.
Describe the solution
Add a new
player_displayfield to amutation_branch, which defaults totrue, and load it from JSON.Change
get_mutations()to take an optional boolean,include_hidden, which defaults totrue. If it isfalse, traits withplayer_displayset tofalseare not returned byget_mutations(). Passfalseto theget_mutations()call inplayer_display.cpp.Set
"player_display": falsethe NPC only traits for the Tacoma Commune and the survivor background story traits.Describe alternatives you've considered
I could have added a specialized get_display_mutations() call but I don't think that's necessary at this time.