Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Inside/outside and daytime/nighttime to a property of a sound instead of a dedicated sound #55095

Closed
Fris0uman opened this issue Feb 4, 2022 · 0 comments · Fixed by #55633
Labels
<Enhancement / Feature> New features, or enhancements on existing Sound Events Sound events handling in the game

Comments

@Fris0uman
Copy link
Contributor

Fris0uman commented Feb 4, 2022

Is your feature request related to a problem? Please describe.

Currently there is only one sound for being inside and one inside_rain to play if it rains outside but nothing for the other weather pattern.
Same thing for daytime/nightime those don't interact with weather or being inside or out.

And weather that you should mainly here when you're outside keeps playing when you're inside

Solution you would like.

Similar to #52295 and it's solution #52308

Add a is_night bool that default to false to sounds so that they can differ at night
Add a similar is_inside to replace Inside/outside entries

Obsolete the hardcoded sound for inside,outside night and day because they should be covered by the various weather effect instead now.

Describe alternatives you have considered.

Use flags instead of bool

"flags": [ "NIGHT", "INSIDE" ]

Additional context

@wapcaplet wapcaplet added Sound Events Sound events handling in the game <Enhancement / Feature> New features, or enhancements on existing labels Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing Sound Events Sound events handling in the game
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants