Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log messages for damage over time #40256

Closed
KorGgenT opened this issue May 6, 2020 · 3 comments
Closed

Add log messages for damage over time #40256

KorGgenT opened this issue May 6, 2020 · 3 comments
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. Mechanics: Character / Player Character / Player mechanics stale Closed for lack of activity, but still valid.

Comments

@KorGgenT
Copy link
Member

KorGgenT commented May 6, 2020

Is your feature request related to a problem? Please describe.

If you are subjected to damage over time, there is no log message. For a good user experience, it is good to have some kind of messaging to tell you why you are losing HP. Additionally, it might be useful to have some kind of visible "effect" on a monster to see that they are under a damage over time effect.

Describe the solution you'd like

A message in the log whenever you take a damage over time tick minus whatever your armor blocks. If you aren't taking damage, no message. I'd say that including the damage type is a plus.

Additional context

This isn't very noticeable right now because not very many things use damage over time, but in the near future I will be writing a spell update that will include damage over time a lot. If you get hi by a monster's spell and start taking damage over time, it would be much better for the player to be able to notice - it could even be something that shows up in the @ screen in the effects menu so you know how long the effect will last, at least in magiclysm.

@KorGgenT KorGgenT added <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics labels May 6, 2020
@stale
Copy link

stale bot commented Jun 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jun 5, 2020
@anothersimulacrum anothersimulacrum added the Info / User Interface Game - player communication, menus, etc. label Jun 5, 2020
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Jun 5, 2020
@stale
Copy link

stale bot commented Jul 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jul 5, 2020
@stale
Copy link

stale bot commented Aug 5, 2020

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. Mechanics: Character / Player Character / Player mechanics stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

2 participants