Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer unload or reload canteens/flasks/containers with liquid contents #40179

Closed
Resok opened this issue May 5, 2020 · 2 comments
Closed
Labels
<Bug> This needs to be fixed Items: Containers Things that hold other things

Comments

@Resok
Copy link
Contributor

Resok commented May 5, 2020

Describe the bug

When attempting to interact with a bottle, canteen, etc. I can no longer unload/reload contents from them. Say I have a canteen in my inventory, or worn - I can no longer fill this with the contents from another bottle.

Steps To Reproduce

  1. Use debug menu to spawn in an empty plastic canteen
  2. Use debug menu to spawn in a container of hydrogen peroxide
  3. Open player inventory and attempt to unload the contents of the plastic bottle of hydrogen peroxide

Result:

Message 'The liquid can't be unloaded in its current state' is displayed and the UI option for unload/reload/part reload is greyed out.

Expected behavior

User should be able to unload containers with liquids into other containers of the same liquid or empty containers that can contain liquids.

Screenshots

image

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1909
  • Game Version: 0.E-1758-g7161a41 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Magiclysm [magiclysm],
    Stats Through Skills [StatsThroughSkills],
    Mutant Animals [mutant_animals],
    Mutant Insects [mutant_insects],
    Classes and Scenarios Mod [more_classes_scenarios],
    Sleep Deprivation [sleepdeprivation]
    ]

Additional context

Note that the hydrogen peroxide item is now considered a container only for purposes of sorting and categories. This makes just about any kind of chemical/liquid to be sorted as a container, which is not useful.

Edit -

Looks like some containers work as expected - Gallon jugs appear fine to unload?

@KorGgenT KorGgenT added <Bug> This needs to be fixed Items: Containers Things that hold other things labels May 8, 2020
@KorGgenT
Copy link
Member

This is a slightly different bug than advertised - the hydrogen peroxide is frozen, and you can't unload frozen liquids.

@RoyBerube
Copy link
Contributor

This has been addressed with PR#44186. Pretty sure it is no longer a problem. Unloading is also working quite well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items: Containers Things that hold other things
Projects
None yet
Development

No branches or pull requests

4 participants