Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item disappears when you try to insert it into a partially-filled container #40115

Closed
FuelType-Memes opened this issue May 4, 2020 · 3 comments · Fixed by #40271
Closed

Item disappears when you try to insert it into a partially-filled container #40115

FuelType-Memes opened this issue May 4, 2020 · 3 comments · Fixed by #40271
Labels
<Bug> This needs to be fixed Items: Containers Things that hold other things (P2 - High) High priority (for ex. important bugfixes)

Comments

@FuelType-Memes
Copy link
Contributor

Describe the bug

My aluminum bat disappears when I try to put it into my partially-filled utility vest

Steps To Reproduce

  1. Spawn an aluminum bat, a utility vest and 10 baseballs
  2. Put on your vest
  3. Pickup 10 baseballs
  4. Wield your bat
  5. Go to your inventory and try to insert the bat into the vest

Expected behavior

I should get a notification that there is not enough space in my vest and keep the bat

Versions and configuration

  • OS: Windows 10
  • Game Version: 0.E-1662-g686104e
  • Graphics version: Tiles
  • Ingame language: English
  • Mods loaded: None
    -->

Additional context

@KorGgenT KorGgenT added <Bug> This needs to be fixed Items: Containers Things that hold other things labels May 4, 2020
@KorGgenT
Copy link
Member

KorGgenT commented May 4, 2020

I'm currently looking into why it shows up in the screen where you holster the item, because can_contain() should return false

@KorGgenT
Copy link
Member

KorGgenT commented May 4, 2020

so apparently there's some shenanigans where the holster item (the item you're trying to put the bat into) gets copied with no contents, making it seem like it actually can contain it. i've spent myself today, though, so i'll have to get back to it later if someone else doesn't get to it first.

@Erozaxx
Copy link

Erozaxx commented May 4, 2020

so apparently there's some shenanigans where the holster item ....

Please check my issue reffered above (#40133) I think it is the same problem and there is no "holster" involved in my case. Yet the behaviour is simillar.

Also I think this:

I'm currently looking into why it shows up in the screen where you holster the item, because can_contain() should return false

Is completely separate issue. In my case, if I wield in hands Quarterstaff and use "w" to unwield it, I get offered only the option to drop it on ground. But if I wield the Duffelbag with items inside, I get option to store it in inventory, which in turn autoinserts the Duffelbag into the Backpack, which does not have enough space and the item disappears. But if I manually try to insert the Quarterstaff into the Backpack (via Insert option in Backpack item detail) I still can do it and the Quarterstaff disappears too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items: Containers Things that hold other things (P2 - High) High priority (for ex. important bugfixes)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants