Construction zones not working properly

[eilaattwood]

Describe the bug

#31340 is not working as intended.
NPCs are reporting that construction is complete immediately after assignation of the task. Of course, they don't construct anything. Trying to complete blueprint by myself (Shift+O) results in infinite loop.

Steps To Reproduce

Steps to reproduce the behavior:

1. Load provided save.
2. Command NPC to work on construction blueprint.
3. Press Shift+O, then choose to work on construction blueprint.
4. Observe effect.

Expected behavior

It should be possible to work on blueprints.

Screenshots

None

Versions and configuration

• OS: Windows 7
• Game Version: 0.D-4923-gf26f75a
• Graphics version: Tiles
• Mods loaded: [
  "dda",
  "no_npc_food",
  "filthy_morale",
  "craftgp",
  "safeautodoc",
  "aftershock",
  "realguns",
  "More_Survival_Tools",
  "Medieval_Stuff",
  "makeshift",
  "modular_turrets",
  "Salvaged_Robots",
  "Mining_Mod",
  "mutant_npcs",
  "alt_map_key",
  "cityside",
  "more_locations",
  "FujiStruct",
  "Urban_Development",
  "boats",
  "blazemod",
  "deoxymod",
  "Tanks",
  "DP_REMIX_INDICATORS",
  "EngineeringEssentials",
  "StatsThroughSkills",
  "sleepdeprivation",
  "more_classes_scenarios",
  "manualbionicinstall"
  ]

Additional context

save.zip
Required mod is here. Or you could try to delete it from the savefile mod list, nothing awful should happen.

[eilaattwood]

Looks like It's happening when construction area has not enough lighting. So some checks has to be added to the zone task code. Maybe NPCs should grab light sources when trying to construct? :)

[eilaattwood]

Also such behavior is possible if no tools available in the construction zone. It's really need to be checked and information message about missing requirements shod be shown, because such behavior is not just confusing, but also dangerous as it can cause infinite loops for NPC or even a player.