iwyu: always include "input.h" directly; remove excessive includes

for all files that iwyu reports as (it should add or remove "input.h")
{
	add / remove "input.h" according to iwyu;
	remove everything iwyu reports to remove;
	while (doesn't compile) {add directly what needs to be added};
	/* note: thanks to indirect includes, we don't need to include most of what iwyu reports
	we obey iwyu only for "input.h", everything else is a suggestion if it doesn't compile without it
}

src/calendar_ui.cpp

@@ -1,9 +1,9 @@
 #include "calendar_ui.h"
 
+#include "input.h"
 #include "string_formatter.h"
 #include "string_input_popup.h"
 #include "ui.h"
-#include "ui_manager.h"
 
 time_point calendar_ui::select_time_point( time_point initial_value, std::string_view title,
         calendar_ui::granularity granularity_level )

src/distraction_manager.cpp

@@ -1,10 +1,10 @@
 #include "distraction_manager.h"
 
-#include <functional>
 #include <string>
 
 #include "color.h"
 #include "cursesdef.h"
+#include "input.h"
 #include "output.h"
 #include "point.h"
 #include "translations.h"

src/do_turn.cpp

@@ -9,21 +9,18 @@
 #include "bionics.h"
 #include "cached_options.h"
 #include "calendar.h"
-#include "character.h"
-#include "creature_tracker.h"
 #include "event_bus.h"
 #include "explosion.h"
 #include "game.h"
 #include "gamemode.h"
 #include "help.h"
-#include "kill_tracker.h"
+#include "input.h"
 #include "make_static.h"
 #include "map.h"
 #include "mapbuffer.h"
 #include "memorial_logger.h"
 #include "messages.h"
 #include "mission.h"
-#include "monattack.h"
 #include "mtype.h"
 #include "music.h"
 #include "npc.h"
@@ -33,13 +30,11 @@
 #include "popup.h"
 #include "scent_map.h"
 #include "sdlsound.h"
-#include "string_input_popup.h"
 #include "stats_tracker.h"
 #include "timed_event.h"
 #include "ui_manager.h"
 #include "vehicle.h"
 #include "vpart_position.h"
-#include "wcwidth.h"
 #include "worldfactory.h"
 
 static const activity_id ACT_AUTODRIVE( "ACT_AUTODRIVE" );

src/gamemode_tutorial.cpp

@@ -1,29 +1,22 @@
 #include "gamemode_tutorial.h" // IWYU pragma: associated
 
-#include <cstdlib>
-#include <iosfwd>
 #include <memory>
 #include <optional>
 
 #include "action.h"
 #include "avatar.h"
 #include "calendar.h"
 #include "character.h"
-#include "colony.h"
 #include "coordinates.h"
 #include "debug.h"
 #include "game.h"
-#include "game_constants.h"
-#include "input.h"
-#include "inventory.h"
 #include "item.h"
 #include "map.h"
 #include "map_iterator.h"
 #include "mapdata.h"
 #include "output.h"
 #include "overmap.h"
 #include "overmapbuffer.h"
-#include "pimpl.h"
 #include "point.h"
 #include "profession.h"
 #include "scent_map.h"

src/init.cpp

@@ -20,7 +20,6 @@
 #include "butchery_requirements.h"
 #include "cata_assert.h"
 #include "cata_scope_helpers.h"
-#include "cata_utility.h"
 #include "character_modifier.h"
 #include "city.h"
 #include "climbing.h"
@@ -46,11 +45,11 @@
 #include "flag.h"
 #include "gates.h"
 #include "harvest.h"
+#include "input.h"
 #include "item_action.h"
 #include "item_category.h"
 #include "item_factory.h"
 #include "itype.h"
-#include "json.h"
 #include "json_loader.h"
 #include "loading_ui.h"
 #include "lru_cache.h"
@@ -79,7 +78,6 @@
 #include "overmap.h"
 #include "overmap_connection.h"
 #include "overmap_location.h"
-#include "path_info.h"
 #include "profession.h"
 #include "profession_group.h"
 #include "proficiency.h"
@@ -98,7 +96,6 @@
 #include "speech.h"
 #include "speed_description.h"
 #include "start_location.h"
-#include "string_formatter.h"
 #include "test_data.h"
 #include "text_snippets.h"
 #include "translations.h"

src/item_factory.cpp

@@ -4,17 +4,13 @@
 #include <array>
 #include <cmath>
 #include <cstdio>
-#include <cstdlib>
 #include <iterator>
 #include <limits>
 #include <memory>
-#include <new>
 #include <optional>
 #include <stdexcept>
-#include <type_traits>
 #include <unordered_set>
 
-#include "addiction.h"
 #include "ammo.h"
 #include "assign.h"
 #include "bodypart.h"
@@ -36,11 +32,11 @@
 #include "game_constants.h"
 #include "generic_factory.h"
 #include "init.h"
+#include "input.h"
 #include "item.h"
 #include "item_contents.h"
 #include "item_group.h"
 #include "iuse_actor.h"
-#include "json.h"
 #include "material.h"
 #include "options.h"
 #include "pocket_type.h"

src/iuse.cpp

@@ -10,7 +10,6 @@
 #include <iterator>
 #include <list>
 #include <map>
-#include <new>
 #include <optional>
 #include <set>
 #include <sstream>
@@ -30,9 +29,9 @@
 #include "calendar.h"
 #include "cata_utility.h"
 #include "character.h"
+#include "construction.h"
 #include "character_martial_arts.h"
 #include "city.h"
-#include "colony.h"
 #include "color.h"
 #include "coordinate_conversions.h"
 #include "coordinates.h"
@@ -56,14 +55,14 @@
 #include "handle_liquid.h"
 #include "harvest.h"
 #include "iexamine.h"
+#include "input.h"
 #include "inventory.h"
 #include "inventory_ui.h"
 #include "item.h"
 #include "item_location.h"
 #include "item_pocket.h"
 #include "iteminfo_query.h"
 #include "itype.h"
-#include "iuse_actor.h" // For firestarter
 #include "json.h"
 #include "json_loader.h"
 #include "line.h"
@@ -103,18 +102,15 @@
 #include "string_input_popup.h"
 #include "teleport.h"
 #include "text_snippets.h"
-#include "timed_event.h"
 #include "translations.h"
 #include "trap.h"
 #include "try_parse_integer.h"
 #include "type_id.h"
 #include "ui.h"
 #include "ui_manager.h"
-#include "units.h"
 #include "units_utility.h"
 #include "value_ptr.h"
 #include "veh_interact.h"
-#include "veh_type.h"
 #include "vehicle.h"
 #include "viewer.h"
 #include "vitamin.h"
@@ -392,7 +388,6 @@ static constexpr int RADIO_PER_TURN = 25;
 
 #include "iuse_software.h"
 
-struct extended_photo_def;
 struct object_names_collection;
 
 static void item_save_monsters( Character &p, item &it, const std::vector<monster *> &monster_vec,

src/loading_ui.cpp

@@ -1,10 +1,10 @@
 #include "loading_ui.h"
 
-#include <functional>
 #include <memory>
 #include <vector>
 
 #include "cached_options.h"
+#include "input.h"
 #include "color.h"
 #include "output.h"
 #include "translations.h"

src/map.cpp

@@ -5,7 +5,6 @@
 #include <climits>
 #include <cmath>
 #include <cstdlib>
-#include <cstring>
 #include <optional>
 #include <ostream>
 #include <queue>
@@ -40,8 +39,6 @@
 #include "do_turn.h"
 #include "drawing_primitives.h"
 #include "enums.h"
-#include "event.h"
-#include "event_bus.h"
 #include "explosion.h"
 #include "field.h"
 #include "field_type.h"
@@ -51,6 +48,7 @@
 #include "game.h"
 #include "harvest.h"
 #include "iexamine.h"
+#include "input.h"
 #include "item.h"
 #include "item_category.h"
 #include "item_factory.h"
@@ -76,8 +74,6 @@
 #include "mongroup.h"
 #include "monster.h"
 #include "mtype.h"
-#include "npc.h"
-#include "options.h"
 #include "output.h"
 #include "overmapbuffer.h"
 #include "pathfinding.h"
@@ -94,7 +90,6 @@
 #include "string_formatter.h"
 #include "submap.h"
 #include "tileray.h"
-#include "timed_event.h"
 #include "translations.h"
 #include "trap.h"
 #include "ui_manager.h"

src/mapbuffer.cpp

@@ -3,19 +3,16 @@
 #include <chrono>
 #include <exception>
 #include <filesystem>
-#include <functional>
-#include <ratio>
 #include <set>
 #include <sstream>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "cata_utility.h"
-#include "coordinate_conversions.h"
 #include "debug.h"
 #include "filesystem.h"
-#include "game_constants.h"
+#include "input.h"
 #include "json.h"
 #include "map.h"
 #include "output.h"

src/mapgen.cpp

@@ -4,11 +4,8 @@
 #include <array>
 #include <cmath>
 #include <cstdlib>
-#include <functional>
-#include <list>
 #include <map>
 #include <memory>
-#include <new>
 #include <optional>
 #include <ostream>
 #include <set>
@@ -39,12 +36,11 @@
 #include "game_constants.h"
 #include "generic_factory.h"
 #include "global_vars.h"
-#include "init.h"
+#include "input.h"
 #include "item.h"
 #include "item_factory.h"
 #include "item_group.h"
 #include "itype.h"
-#include "json.h"
 #include "level_cache.h"
 #include "line.h"
 #include "magic_ter_furn_transform.h"

src/mattack_actors.cpp

@@ -2,7 +2,6 @@
 
 #include <algorithm>
 #include <limits>
-#include <list>
 #include <memory>
 #include <optional>
 #include <string>
@@ -17,10 +16,10 @@
 #include "game.h"
 #include "generic_factory.h"
 #include "gun_mode.h"
+#include "input.h"
 #include "item.h"
 #include "item_factory.h"
 #include "item_pocket.h"
-#include "json.h"
 #include "line.h"
 #include "map.h"
 #include "map_iterator.h"

src/medical_ui.cpp

@@ -1,12 +1,9 @@
 #include <algorithm>
 #include <cmath>
 #include <cstdlib>
-#include <numeric>
-#include <set>
 #include <string>
 #include <utility>
 
-#include "action.h"
 #include "addiction.h"
 #include "avatar_action.h"
 #include "creature.h"
@@ -16,9 +13,9 @@
 #include "effect.h"
 #include "flag.h"
 #include "game.h"
+#include "input.h"
 #include "output.h"
 #include "ui_manager.h"
-#include "vitamin.h"
 #include "weather.h"
 
 static const efftype_id effect_bite( "bite" );

src/past_games_info.cpp

@@ -1,9 +1,7 @@
 #include "past_games_info.h"
 
 #include <algorithm>
-#include <functional>
 #include <map>
-#include <sstream>
 #include <stdexcept>
 #include <string>
 #include <utility>
@@ -13,7 +11,7 @@
 #include "debug.h"
 #include "event.h"
 #include "filesystem.h"
-#include "json.h"
+#include "input.h"
 #include "json_loader.h"
 #include "memorial_logger.h"
 #include "output.h"

src/player_hardcoded_effects.cpp

@@ -20,6 +20,7 @@
 #include "field_type.h"
 #include "fungal_effects.h"
 #include "game.h"
+#include "input.h"
 #include "make_static.h"
 #include "map.h"
 #include "map_iterator.h"
@@ -39,7 +40,6 @@
 #include "units.h"
 #include "vitamin.h"
 #include "weather.h"
-#include "weather_type.h"
 
 static const activity_id ACT_FIRSTAID( "ACT_FIRSTAID" );