-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCP redirection guide #360
Conversation
Deployment has finished 👁️👄👁️ Your app is available here |
Thanks for this PR @Dekabry, I will check it out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, see suggestions according to editorial linter.
Reformulating quite a lot of things :) Co-authored-by: Julia March <[email protected]> Co-authored-by: Clément Nivolle <[email protected]>
🚀 You updated your review app. Check it here |
Assigned @Keksoj and/or @Wonshtrum to review the content. This is the preview: http://documentation-pr-360.cleverapps.io/doc/administrate/tcp-redirections/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, but some paragraph seem to have been left from the old version and should be deleted. I think some parts could be reworked a little too.
🚀 You updated your review app. Check it here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small syntax improvements and it should be good to go
Co-authored-by: Julia March <[email protected]>
Co-authored-by: Julia March <[email protected]>
Co-authored-by: Julia March <[email protected]>
🚀 You updated your review app. Check it here |
🚀 You updated your review app. Check it here |
Describe your PR
Added guide to explain how to enable TCP redirection on the console.
Reworked some explanations.
Improved overall structure/style for readability.
Checklist
Reviewers
Who should review these changes? @cnivolle @juliamrch