Update Hugo deploy script #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davlgd
commented
Dec 16, 2023
davlgd
commented
- Add shebang
- Add vars at the begining of the script
- Clean archive after download
- Use folder in $PATH
- Add shebang - Add vars at the begining of the script - Clean archive after download - Use folder in $PATH
davlgd
temporarily deployed
to
PR review apps
GitHub Actions
Inactive
|
Deployment has finished 👁️👄👁️ Your app is available here |
|
Why is this needed? |
It's not "needed", I just iterated on the original script with elements mentioned in the commit message. |
cnivolle
reviewed
Dec 21, 2023
There was a problem hiding this comment.
Hi @davlgd and thank your for your submission,
Regarding the pull request template, this PR is not matching any the following changes :
- This is not a documentation content changes
- This is not fixing a bug on the site
- This doesn't change the build process, as it is the same Hugo build command
This add complexity to the actual build change, leading to fewer people to understand the build process. Especially because this PR add local variable to the file, along with Clever Cloud environment variables. This might be confusing for future maintenance. The simpler the better.
juliamrch
reviewed
Dec 21, 2023
|
Your review app has been deleted 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.