Add workaround for inclusive namespaces #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applies all inclusive namespaces for signature assertions onto assertion tag used as recommended workaround for xml-crypto library limitation with inclusive namespaces see node-saml/xml-crypto#48 (comment)
| add_namespaces_to_child_assertions = (xml_string) -> | ||
| doc = new xmldom.DOMParser().parseFromString xml_string | ||
|
|
||
| response_elements = doc.getElementsByTagNameNS "urn:oasis:names:tc:SAML:2.0:protocol", "Response" |
There was a problem hiding this comment.
You can use the constant XMLNS.SAMLP
johnhuangclever
force-pushed
the
inclusive-namespaces-workaround
branch
2 times, most recently
from
ea2394e to
bc8c657
Compare
|
lgtm. |
johnhuangclever
force-pushed
the
inclusive-namespaces-workaround
branch
from
bc8c657 to
f2fa58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applies all inclusive namespaces for signature assertions onto assertion tag
used as recommended workaround for xml-crypto library limitation with inclusive namespaces see
node-saml/xml-crypto#48 (comment)