-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node-forge vulnerabilities #248
Comments
Would be interested in fix for this. The newer version of xml-encryption (2.0.0) seems to be api compatible. With nodejs 16.x added a dependency override in my package.json as in below and it worked with current release of saml2-js.
|
I am mainting a fork of this repo with all dependency updates applied. Feel free to use it in any case. |
mcab
added a commit
that referenced
this issue
Oct 15, 2022
mcab
added a commit
that referenced
this issue
Oct 15, 2022
mcab
added a commit
that referenced
this issue
Oct 15, 2022
mcab
added a commit
that referenced
this issue
Oct 15, 2022
Addressed in #261. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The node-forge version used in node-xml-encryption that saml2 uses has some vulnerabilities.
https://deps.dev/advisory/GHSA/GHSA-5rrq-pxf6-6jx5 - Prototype Pollution in node-forge debug API.
and also
https://deps.dev/advisory/GHSA/GHSA-gf8q-jrpm-jvxq - URL parsing in node-forge could lead to undesired behavior.
This was fixed in the newest version of node-xml-encryption:
auth0/node-xml-encryption#94
So upgrading node-xml-encryption to the latest release should fix this.
Can we expect this to be fixed any time soon?
The text was updated successfully, but these errors were encountered: