Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: combine process column code #1622

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Nov 14, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

This combines some of the kinda duplicated code around process columns across options and the actual data.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang enabled auto-merge (squash) November 14, 2024 10:19
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 64.60177% with 40 lines in your changes missing coverage. Please review.

Project coverage is 41.84%. Comparing base (103c4f6) to head (835ec66).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/widgets/process_table/process_columns.rs 61.19% 26 Missing ⚠️
src/widgets/process_table.rs 78.04% 9 Missing ⚠️
src/widgets/process_table/process_data.rs 0.00% 3 Missing ⚠️
src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   41.89%   41.84%   -0.05%     
==========================================
  Files         114      114              
  Lines       17639    17621      -18     
==========================================
- Hits         7389     7374      -15     
+ Misses      10250    10247       -3     
Flag Coverage Δ
macos-12 37.26% <64.60%> (-0.06%) ⬇️
ubuntu-latest 43.62% <64.60%> (-0.05%) ⬇️
windows-2019 37.17% <64.60%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang merged commit 6d37d57 into main Nov 14, 2024
36 checks passed
@ClementTsang ClementTsang deleted the refactor_process_columns branch November 14, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant