Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support \ in linux temporary path #982

Closed
bhelgs opened this issue Jul 11, 2024 · 3 comments · Fixed by #985
Closed

support \ in linux temporary path #982

bhelgs opened this issue Jul 11, 2024 · 3 comments · Fixed by #985
Labels
help wanted

Comments

@bhelgs
Copy link
Contributor

bhelgs commented Jul 11, 2024 •
edited
Loading

What action do you want to perform

By default pytest temporary paths on AWS workspaces will contain a \ in the temporary path due to their username conventions.

Maybe you might want to support \ in paths?
Some additional command quotes seem fix the \ issue and may help with other special linux path characters.

What are the results

Temporary data is generated under /tmp/ACTIVEDIRECTORY\user.name/pytest-101/pytest-postgresql-postgresql_proc0/ but some commands lost the \

What are the expected results

I was able to run without issue after quoting the paths in PostgreSQLExecutor.BASE_PROC_START_COMMAND and PostgreSQLExecutor.running()

Workaround

set --basetemp= argument in pytest command
@bhelgs
Copy link
Contributor Author

bhelgs commented Jul 11, 2024

Thank you very much for creating such a great project! 🏆
Please let me know if you would like for me to open a couple line PR.

@bhelgs bhelgs changed the title support \ (special character) in linux temporary path support \ in linux temporary path Jul 11, 2024
@fizyk
Copy link
Member

fizyk commented Jul 16, 2024

@bhelgs if you're able to probide PR with fix (and test preferably), please go ahead :)

bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 16, 2024
@bhelgs
add support for \ character in pytest tmp_path_factory - closes Clear…
3fdfada 
…codeHQ#982
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 16, 2024
@bhelgs
add support for \ character in pytest temporary path - closes Clearco…
dd5f6d4 
…deHQ#982
@bhelgs bhelgs mentioned this issue Jul 16, 2024
Closed
1 task
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 16, 2024
@bhelgs
add support for \ character in pytest temporary path - closes Clearco…
9031803 
…deHQ#982
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 17, 2024
@bhelgs
test for \ in tmp path (ClearcodeHQ#982)
6fff3f2
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 17, 2024
@bhelgs
test for \ in tmp path (ClearcodeHQ#982)
b308c82
@bhelgs bhelgs mentioned this issue Jul 17, 2024
Merged
1 task
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 17, 2024
@bhelgs
test for \ in tmp path (ClearcodeHQ#982)
366744f
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 17, 2024
@bhelgs
add support for \ character in pytest temporary path - Closes Clearco…
4734c6b 
…deHQ#982
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 18, 2024
@bhelgs
add support for \ character in pytest temporary path - Closes Clearco…
e6768eb 
…deHQ#982
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 18, 2024
@bhelgs
add support for \ character in pytest temporary path - Closes Clearco…
9681a5a 
…deHQ#982
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 22, 2024
@bhelgs
test for \ in tmp path (ClearcodeHQ#982)
1dd8104
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 22, 2024
@bhelgs
add support for \ character in pytest temporary path - Closes Clearco…
107a56b 
…deHQ#982
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Jul 22, 2024
@bhelgs
add support for \ character in pytest temporary path - Closes Clearco…
662a92e 
…deHQ#982
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Sep 3, 2024
@bhelgs
test for \ in tmp path (ClearcodeHQ#982)
215ddc9
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Sep 3, 2024
@bhelgs
add support for \ character in pytest temporary path - Closes Clearco…
c0d04f8 
…deHQ#982
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Sep 3, 2024
@bhelgs
test for \ in tmp path (ClearcodeHQ#982)
0d9c0cb
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Sep 3, 2024
@bhelgs
add support for \ character in pytest temporary path - Closes Clearco…
802a667 
…deHQ#982
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Sep 3, 2024
@bhelgs
test for \ in tmp path (ClearcodeHQ#982)
bf18cc0
bhelgs added a commit to bhelgs/pytest-postgresql that referenced this issue Sep 3, 2024
@bhelgs
add support for \ character in pytest temporary path - Closes Clearco…
a24d7dc 
…deHQ#982
@fizyk fizyk closed this as completed in #985 Sep 4, 2024
fizyk added a commit that referenced this issue Sep 4, 2024
@fizyk
Merge pull request #985 from bhelgs/bad_tmp_path
fa9432a 
add support for `\` character in pytest temporary path - Closes #982
@fizyk
Copy link
Member

fizyk commented Sep 4, 2024

And we have a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
2 participants
@fizyk @bhelgs