Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shadows added for negative values #75

Merged
merged 1 commit into from
Mar 4, 2021
Merged

fix: shadows added for negative values #75

merged 1 commit into from
Mar 4, 2021

Conversation

pappijx
Copy link
Contributor

@pappijx pappijx commented Mar 3, 2021 •
edited
Loading

Checklist

  • PR is up-to-date with a description of changes and screenshots (if applicable).
  • All files are lint-free.
  • Followed Semantic PR guidelines.
  • Tested locally for regressions.

@pappijx pappijx requested a review from anshul-pinto0410 March 3, 2021 14:59
@pappijx pappijx self-assigned this Mar 3, 2021
shivaprasadks
shivaprasadks approved these changes Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@shivaprasadks shivaprasadks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pappijx pappijx merged commit ddbefeb into develop Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivaprasadks shivaprasadks shivaprasadks approved these changes

@anshul-pinto0410 anshul-pinto0410 Awaiting requested review from anshul-pinto0410

@pritam248 pritam248 Awaiting requested review from pritam248

Assignees

@pappijx pappijx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pappijx @shivaprasadks