Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: feedback changes #49

Merged
merged 4 commits into from
Nov 25, 2020
Merged

feat: feedback changes #49

merged 4 commits into from
Nov 25, 2020

Conversation

anshul-pinto0410
Copy link
Contributor

Checklist

  • PR is up-to-date with a description of changes and screenshots (if applicable).
  • All files are lint-free.
  • Followed Semantic PR guidelines.
  • Tested locally for regressions.

pritam248
pritam248 reviewed Nov 24, 2020
View reviewed changes
src/components/Branding/branding.css
@@ -30,15 +30,15 @@

@screen sm {
.lil-brand-text {
bottom: -4rem;
bottom: -2rem;
Copy link
Contributor

@pritam248 pritam248 Nov 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified for all pages ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, only changes spacing for branding text

pritam248
pritam248 reviewed Nov 24, 2020
View reviewed changes
src/components/Common/common.css Outdated
@@ -18,6 +18,17 @@ select {
border-spacing: 0;
}

.lil-guitar {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO guitar or any bg shud not be inside littlegiant .... @shivaprasadks plz suggest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this and replaced with positioning, although had to add max width config class

pritam248
pritam248 reviewed Nov 25, 2020
View reviewed changes
tailwind.config.js
Comment on lines +157 to +159
maxWidth:{
'screen-xl': "1440px",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed ? we shud not restrict...its already covered in container class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

container has x padding, this will be of use for any full screen section to allign properly with container if it requires elements outside conainer

@anshul-pinto0410 anshul-pinto0410 merged commit e1b3288 into development Nov 25, 2020
@anshul-pinto0410 anshul-pinto0410 deleted the feat/feedback-fix branch November 25, 2020 07:20
pritam248 added a commit that referenced this pull request Dec 3, 2020
@pritam248 @anshul-pinto0410 @shivaprasadks
Release v1.0.0 🎉🚀 (#54)
f01d0fc 
* chore: updated dependencies

* Feat/components setup (#2)

* feat: added btn, text, cards component

* feat: updated doc for fontsize

* feat: styling changes for promise content

* feat: responsive font-size for header tag

* feat: btn display, promise card 4 col view

* fix: removed custom font

* feat: promise vertical, btn white component (#4)

* feat: added faq and press cards (#5)

* feat: added faq and press cards

* feat: solved comments

* feat: added reinforcement card

* feat: fixed comments

* feat: fixed more comments

Co-authored-by: anshul-pinto0410 <[email protected]>

* feat: color, font color standardisation (#9)

* Feat/Tabs component (#7)

* feat: tabs componentn css classes

* added eof

* removed subheading in tab docs

* chore: updated tab color

* feat: container config (#10)

* Feat/Carousel card, Textbox, bg with color standardisation (#8)

* feat: added faq and press cards

* feat: solved comments

* feat: added reinforcement card

* feat: fixed comments

* feat: fixed more comments

* feat: carousel card

* feat: input field added/fixed focus effect on buttons

* feat: updated all colors with standard set

* feat: removed wrappers and resolved comments

Co-authored-by: anshul-pinto0410 <[email protected]>
Co-authored-by: Pritam Sinha <[email protected]>

* Feat/new UX changes, fixes for existing components (#11)

* feat: new UX changes, fixes for existing components

* fix: added EOF for common.css

* fix: added EOF for navbar.css

* Feat/design updates (#12)

* feat: added faq and press cards

* feat: solved comments

* feat: added reinforcement card

* feat: fixed comments

* feat: fixed more comments

* feat: carousel card

* feat: input field added/fixed focus effect on buttons

* feat: updated all colors with standard set

* feat: removed wrappers and resolved comments

* feat: Made design changes

* feat: resolved comments

* feat: changed card width

* feat: changed card width

Co-authored-by: anshul-pinto0410 <[email protected]>
Co-authored-by: Pritam Sinha <[email protected]>

* feat: updated carousel (#14)

Co-authored-by: anshul-pinto0410 <[email protected]>

* feat: font weight standards (#16)

* fix: size, margin for card, added padding for container resposiveness (#18)

* Feat/Dropdown component (#15)

* feat: dropdown for navbar, fix tabs zindex

* fix: top position for dropdown

* feat: variables for colors

fix: dropdown styling issues

* fix: EOF for variables, lilgiant css

* feat: updated font (#17)

* feat:font changes and minor design changes

* feat:EOF common.css

* feat: updated header color added round button

* feat: resolved comments

* feat: resolved comments

* feat: added min width in config plus minor changes

* feat: resolved comments

Co-authored-by: anshul-pinto0410 <[email protected]>

* Feat/header responsiveness (#19)

* feat: added toggle navbar, sidenav

* feat: added details styling, sidebar fix, navbar close icon css

* Feat/Added sidebar, caret, toggle for nav (#20)

* feat: added toggle navbar, sidenav

* feat: added details styling, sidebar fix, navbar close icon css

* fix: removed horizontal margin for nav links

* fix: sidebar opening/close css class (#21)

* Feat/bug fixes (#22)

* feat: Minor bug fixes

* feat: changes to accomodate interactions

* feat: removed extra css

* feat: resolved comments

Co-authored-by: anshul-pinto0410 <[email protected]>
Co-authored-by: Pritam Sinha <[email protected]>

* fix: md styling for normal cards (#23)

* feat: added no outline class for interactive components (#24)

Co-authored-by: anshul-pinto0410 <[email protected]>

* feat: added fallback colors for css var (#25)

* fix: proper container alignment for all screen (#27)

* fix: vertical alignment for containers (#28)

* feat: header height fix plus caret (#26)

* feat: header height fix plus caret

* feat: updated caret with css style

* feat: changed arrow dir

* feat: solved caret colour issue

Co-authored-by: anshul-pinto0410 <[email protected]>
Co-authored-by: Pritam Sinha <[email protected]>

* feat: fixed testimonial (#29)

Co-authored-by: anshul-pinto0410 <[email protected]>
Co-authored-by: Pritam Sinha <[email protected]>

* Fix/Default cards content styling (#31)

* fix: default card styling

* fix: tab active font color

* feat: added bg blur class for navbar

* feat: updated components from feedback (#30)

Co-authored-by: anshul-pinto0410 <[email protected]>
Co-authored-by: Pritam Sinha <[email protected]>

* feat: added accordian caret (#32)

* feat: fixed hover effects on tabs (#33)

Co-authored-by: anshul-pinto0410 <[email protected]>

* fix: nav bar dropdown styling fixes (#34)

* fix: nav bar dropdown styling fixes

* feat: remove hover effect on nav menu

* fix: caret naming class, position

* feat: made component for brands and added max w in config (#35)

* feat: made component for brands and added max w in config

* feat: removed max w config

* feat: updated docs

Co-authored-by: anshul-pinto0410 <[email protected]>
Co-authored-by: Pritam Sinha <[email protected]>

* fix: nav menu, carousel card, card (#36)

* Feat/ca vertical promise (#38)

* feat: vertical promise tabs

* feat: cherry pick

* feat: resolved commit added blue color for tab

Co-authored-by: anshul-pinto0410 <[email protected]>
Co-authored-by: Pritam Sinha <[email protected]>

* Feat/added tick mark (#39)

* feat:added tick

* feat: added tick mark

* feat: resolved comments

Co-authored-by: anshul-pinto0410 <[email protected]>

* feat: vertical tab with line (#40)

* feat: vertical tab with line

* feat: minor changes

* feat: medium font change

* feat: updated tabs as per figma

* feat: resolved comments

Co-authored-by: anshul-pinto0410 <[email protected]>

* Feat/Rounded tabs (#42)

* feat: added rounded tabs styling

* fix: branding txt alignment

* feat: modal component, select tag styling (#43)

* feat: modal component, select tag styling

* fix: modal top position, max height

* feat: product card ca section 3 (#41)

* feat: product card ca section 3

* feat: resolved comments

Co-authored-by: anshul-pinto0410 <[email protected]>

* fix: sticky for capsule tab (#44)

* feat: added clearsky shade (#45)

* feat: new xl tick- button rnd- table (#46)

* feat: new xl tick- button rnd- table

* feat: resolved comments

* feat: added doc for button

* feat: custom class for table resolved comments

* feat: fixed comment

Co-authored-by: anshul-pinto0410 <[email protected]>
Co-authored-by: Pritam Sinha <[email protected]>

* feat: added green shade (#47)

* feat: minor changes to accomodate new assets (#48)

Co-authored-by: anshul-pinto0410 <[email protected]>

* feat: feedback changes (#49)

* feat: feedback changes

* feat: branding changes

* feat: guitar pick

* feat: remove guitar pick add max width config

Co-authored-by: anshul-pinto0410 <[email protected]>

* fix: Carousel & tab fixes (#50)

* feat: corresponding changes w Subham

* feat:resolved comments

Co-authored-by: anshul-pinto0410 <[email protected]>

* feat: added support for ie (#51)

* feat: added support for ie

* fix: reverted navbar bg change

* MARKTECH-628 addition of verticle flat tabs

* MARKTECH-628 addition of custom grey color

* MARKTECH-628 addition of custom shadow

* MARKTECH-628 review changes

* feat: review changes

* feat: branding for enterprise page (#52)

Co-authored-by: anshul-pinto0410 <[email protected]>
Co-authored-by: Pritam Sinha <[email protected]>

* Documentation -  change log added (#55)

* Feat: change log added

* feat: semantic comment

Co-authored-by: anshul-pinto0410 <[email protected]>

* chore: updated version n css (#56)

Co-authored-by: Anshul Pinto <[email protected]>
Co-authored-by: anshul-pinto0410 <[email protected]>
Co-authored-by: Shivaprasad <[email protected]>
Co-authored-by: Shivaprasad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritam248 pritam248 pritam248 approved these changes

@shivaprasadks shivaprasadks Awaiting requested review from shivaprasadks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshul-pinto0410 @pritam248