Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address erroneous NormalizedForm attribute #89

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Address erroneous NormalizedForm attribute #89

merged 2 commits into from
Mar 15, 2024

Conversation

RickBrannan
Copy link
Contributor

No description provided.

@RickBrannan RickBrannan mentioned this pull request Mar 15, 2024
Closed
@RickBrannan
Copy link
Contributor Author

I believe this PR addresses this issue: #88

@RickBrannan RickBrannan linked an issue Mar 15, 2024 that may be closed by this pull request
Presence of non-puncutation characters in TSV after column #88
Closed
@jonathanrobie
Copy link
Contributor

Good work, @RickBrannan. There were LOTS of problems with @NormalizedForm in SBLGNT Node that are fixed here. This now:

  1. Consistently uses lowercase for normalized form
  2. Correctly adjusts accents
  3. Correctly fixes the bug with οὐχ and οὐκ identified in the issue itself.

What we had before in the SBLGNT trees really was not a normalized form, which caused downstream bugs.

@jacobwegner
Copy link
Collaborator

Closes #88

@jacobwegner jacobwegner merged commit ef69ce4 into main Mar 15, 2024
1 check passed
@jacobwegner jacobwegner deleted the fix-normalized-form branch March 15, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Presence of non-puncutation characters in TSV after column
3 participants
@RickBrannan @jonathanrobie @jacobwegner