Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildscript to RFG #14

Merged
merged 5 commits into from
May 17, 2023
Merged

Update buildscript to RFG #14

merged 5 commits into from
May 17, 2023

Conversation

bruberu
Copy link
Contributor

@bruberu bruberu commented May 16, 2023

Updates the buildscript to RFG.
Currently, given the lack of any easy replacement for the replace functionality, I've removed the @Version@ and @modid@ in the main class, which don't seem to be required in the first place, at least. Perhaps this could be re-added. Furthermore, at the time of writing, the diamond test menu crashes, so this should not be merged yet.

@Rongmario
Copy link
Member

Consult this PR for GroovyScript on how to implement replacements with RFG

@bruberu
Copy link
Contributor Author

bruberu commented May 16, 2023

OK, replacements have been implemented.

Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.
I totally know whats going on here.

@brachy84 brachy84 merged commit 858bf83 into CleanroomMC:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants