Make Ender Dragon's XP drop fire LivingExperienceDropEvent for each "batch" of XP #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>this might not be as flexible as people want, but maybe just go for simple: just fire the event once for each "batch" of XP it spawns? the value is known for each batch in this case MinecraftForge/MinecraftForge#4910
Rongmario
requested changes
Feb 24, 2024
patches/minecraft/net/minecraft/entity/boss/EntityDragon.java.patch
Outdated
Show resolved
Hide resolved
patches/minecraft/net/minecraft/entity/boss/EntityDragon.java.patch
Outdated
Show resolved
Hide resolved
Rongmario
requested changes
Feb 25, 2024
| private void func_184668_a(int p_184668_1_) | ||
| { | ||
| + p_184668_1_ = net.minecraftforge.event.ForgeEventFactory.getExperienceDrop(this, this.field_70717_bb, p_184668_1_); | ||
| + if(p_184668_1_>0) |
There was a problem hiding this comment.
if(p_184668_1_>0) isn't needed here.
Rongmario
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MinecraftForge/MinecraftForge#4910 ?