Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply GuiIngameForge options only when running on client #155

Merged
merged 1 commit into from
Jun 3, 2024
Merged

apply GuiIngameForge options only when running on client #155

merged 1 commit into from
Jun 3, 2024

Conversation

ZZZank
Copy link
Contributor

@ZZZank ZZZank commented Jun 3, 2024

This PR:

  • adds a sanity check to prevent applying client-only options when running on server, (which will cause a NoClassDefFoundError)

Testing

Testing is done by running cleanroomServer task from Gradle.

before

before

after

after

@kappa-maintainer kappa-maintainer merged commit 1291659 into CleanroomMC:experimental/foundation Jun 3, 2024
1 check passed
@ZZZank ZZZank deleted the server_crash branch June 3, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rongmario Rongmario Rongmario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZZZank @Rongmario @kappa-maintainer