Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable patch shuffling by default #123

Closed
yellowcap opened this issue Jan 16, 2024 · 1 comment · Fixed by #135
Closed

Disable patch shuffling by default #123

yellowcap opened this issue Jan 16, 2024 · 1 comment · Fixed by #135
Assignees

Comments

@yellowcap
Copy link
Member

Shuffling the patches is important during MAE training, but is confusing and requires extra attention when fine tuning or during inference.

We should have an automatic way of handling this, so that the downstream user does not have to worry about the shuffling at all.

Refs

shuffle=True,

#118 (comment)

@weiji14 weiji14 changed the title Disable patch shuffeling by default Disable patch shuffling by default Jan 24, 2024
@yellowcap
Copy link
Member Author

Could we make this automatic and dependent on inference vs training? Seems like during training it should be always True, and during inference there is no downside of having it always False. Or am I not seeing something here?

yellowcap added a commit that referenced this issue Jan 25, 2024
This removes the shuffle argument and shuffles patches only during training.
Closes #123
yellowcap added a commit that referenced this issue Jan 25, 2024
This removes the shuffle argument and shuffles patches only during training.
Closes #123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants