Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS comment: auto effect_type #5

Closed
DominiqueMakowski opened this issue Nov 3, 2020 · 1 comment
Closed

JOSS comment: auto effect_type #5

DominiqueMakowski opened this issue Nov 3, 2020 · 1 comment

Comments

@DominiqueMakowski
Copy link

Related to openjournals/joss-reviews#2810 :

Currently, if let's say effect_type arg is left to default ("correlation") and we change the test_method to that of a mean difference test, it errors. However, I wonder whether it would be simpler to just have the effect_type adjust automatically based on the input of test_method, especially in straightforward cases like correlations and t-tests?

ClaudioZandonella added a commit that referenced this issue Nov 15, 2020
Let the effect type be defined automatically according to test method.

Update functions, documentation, and unit tests
@ClaudioZandonella
Copy link
Owner

Dear @DominiqueMakowski thanks for pointing out this issue. Initially, we wanted to be sure that the user was aware of the effect type considered; so it was required to specify both the effect_type and test_method argument. However, we agree that this is redundant and most of the times it ends up with annoying error messages. Now, following your suggestion, we let the effect type to be set automatically and the user is required to define only the test method.
At the moment the changes are in the develop branch. We will merge everything in the master branch after the review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants