Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the changes mentioned in #35, plus the removal of the
from pymodbus.compat import iteritems
line, aspymodbus.compat
doesn't exist in version 3, and the line was unused anyways.Summary of changes for
classic_mqtt.py
:Summary of changes for
support/classic_modbusdecoder.py
:pymodbus
version we're usingslave=
for version 3 andunit=
for version 2.I could also just drop support for pymodbus 2, but it seems pretty easy and straightforward to keep it.