Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update material insiders version to latest version #1430

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 3, 2024

Verify the new version works and there are no side effects (theme color reverting). Confirm all checks are passing.


📚 Documentation preview 📚: https://civicactions-handbook--1430.org.readthedocs.build/en/1430/

@github-actions github-actions bot requested a review from a team as a code owner September 3, 2024 17:04
@dmundra
Copy link
Collaborator

dmundra commented Sep 3, 2024

@grugnog PR created successfully but based on the docs https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow it won't trigger other checks to avoid recursive issues. Here is a work around peter-evans/create-pull-request#48 (comment).

Should we try that separate token approach or something else?

@dmundra dmundra requested a review from grugnog September 8, 2024 15:18
@dmundra dmundra force-pushed the update-material-insiders-1725383095 branch from 350d546 to 8561511 Compare September 16, 2024 16:22
@dmundra
Copy link
Collaborator

dmundra commented Sep 16, 2024

I had to rebase after other updates. Hopefully with these changes the next PR for updating insiders would run more cleanly.

@dmundra dmundra force-pushed the update-material-insiders-1725383095 branch from 3ac027f to c4ca7b5 Compare October 1, 2024 15:30
@dmundra dmundra merged commit 956014f into master Oct 17, 2024
13 checks passed
@dmundra dmundra deleted the update-material-insiders-1725383095 branch October 17, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants