-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snitch names to jalist output #77
Conversation
- Added the snitch name column to output - Removed the world name column from output - Added the world name to the first line of the header - Added an optional suffix argument to ChatFiller.fillString (instead of just chopping off an arbitrary number of characters and adding the suffix in JukeAlertLogger.getSnitchList) - JukeAlertLogger.getSnitchList now returns an instance of SendSnitchList. This was necessary to add the world name.
Longer group and snitch names will be truncated, so this allows them to be displayed in full (and parsed by mods like Snitch-Visualizer)
Can one of the admins verify this patch? Type 'ok to test' to test. |
You should consider using rebase instead of local merge, so you don't have 5 merge commits in each PR. Assuming this is tested, it looks nice though. |
Thanks for the tip! I'm still figuring out how to use git. I've tested it locally and it seems fine. |
World names would matter for non-sharded servers. |
That's a good point. I could probably add a config option that enables the world name column, (by reducing the width of the group and snitch name columns), and disables the world name in the header, (since it only displays the world name for the first snitch in the list). Would that work? |
I've added the config option I mentioned. I've tested locally it and it seems to work as intended. The only thing I'm not sure about is the name of the config entry, ('multipleWorldSupport'), since it's referring to multiple worlds on a single server. For Civcraft, multipleWorldSupport would be set to false, (which is the default). |
Ok, nice. Good work |
Fixes #24
I've tested it locally against Spigot 1.10.2 and it seems to work as intended. The columns are a little wonky, but I don't think that's fixable unless Minecraft reverts to a monospaced font.
just chopping off an arbitrary number of characters and adding the
suffix in JukeAlertLogger.getSnitchList)
SendSnitchList. This was necessary to add the world name.