Changes for MDS 0.3.x #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Rebased on |
|
Rebased on |
Closed
This was referenced Apr 24, 2019
Closed
- tweak encoding format for dates
converts datetime to int unix ms when unix is the date_format requested
- encode datetimes for API querystrings
- convert incoming ms to utc timestamp in postgres
mds.version.Version helps parse and compare version strings
client is now single-Provider focused Provider refactored to help acquire/configure a single instance at a time
* using relative imports * import up the package chain * moving schema constants - breaking
* use ConfigFile * use new encoding * allow old/new querystrings regardless of version * clean up Provider usage
* do not exclude any props in .dump() * case-insensitive search for sub-config * remove duplicative _provider property
* copy-constructor for incoming Provider instance * setting some default props directly * compute API endpoints (all data available in Provider instance)
* initialize with Provider instances and kwargs dict * set the Accept header using version * use Provider-computed endpoints
many validation improvements were introduced in 0.2.1, as the schemas in 0.2.0 were overly restrictive for e.g. allowed nulls
some providers are returning data at 0.2.0 which otherwise validates at 0.2.1, and this should be resolved by moving to 0.3.x anyway.
when null, the temp table created by DataFrame can type this column as double precision, failing the later conversion to uuid[] / uuid this transform was missed in the refactor
* the config keyword parameter pulled out of kwargs to more easily directly pass it, with sensible default * extra kwargs are gathered and merged with config, as an additional call style (e.g. with the attribute=value directly vs. in a dict)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress PR.
Running list of tasks (edited to pull together the comment stream below):
bboxper Remove unused bounding box parameter from Provider API openmobilityfoundation/mobility-data-specification#183tripsquerystringsstart_time/end_time->min_end_time/max_end_timeSuggestion to improve time based filtering openmobilityfoundation/mobility-data-specification#139associated_trips->associated_tripinstatus_changesFixing associated_trips #70 and Updated associated trip patch openmobilityfoundation/mobility-data-specification#217publication_timefield per Addpublication_timefields to trips and status changes openmobilityfoundation/mobility-data-specification#329