Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): automated builds upon tagging #911

Merged
merged 1 commit into from
Mar 25, 2018
Merged

feat(ci): automated builds upon tagging #911

merged 1 commit into from
Mar 25, 2018

Conversation

snowypowers
Copy link
Member

This adds the ability to use CI to build upon tagging. I have it setup for linux and windows builds.

How

  1. We will have to tag the build beforehand. Instead of using the release page to tag, we use cmd. Assuming we are on master on the commit that we want to release:
git tag 0.2.3
git push upstream 0.2.3 --no-verify

This will push the tag up and CircleCi should pick this up and trigger the builds.

The builds can be found by going to Workflows -> neon-wallet. The dist folder is uploaded as artifacts. Unfortunately, I do not see anyway to automate the attachement of the builds to the release draft so we will have to do this ourselves.

@mhuggins
Copy link
Contributor

Is the goal/benefit of this so that we can coordinate what commit to build the release from? Is there anything more that is good to know about it?

@mhuggins
Copy link
Contributor

You might need to rebase this against the current dev branch to make your CI build pass.

@snowypowers
Copy link
Member Author

The goal is to automate the builds so that you can have the windows and linux builds without needing us to help build. CircleCI builds and you grab the exe, deb and appImage from the CircleCI site.

@snowypowers
Copy link
Member Author

the test is failing because the trigger is on my branch and not on the coz branch, thus failing at the coveralls step...

@drptbl
Copy link

drptbl commented Mar 24, 2018

@snowypowers I had exactly the same issue with coveralls (here: #895 (comment)) and I couldn't find a way to fix it. Is there any way?

@snowypowers
Copy link
Member Author

@drptbl i just did it. I think setting it to private solves it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 39.655% when pulling 54cedca on snowypowers:feat/cd into d6e2e65 on CityOfZion:dev.

Copy link
Contributor

@mhuggins mhuggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mhuggins mhuggins merged commit 707212c into CityOfZion:dev Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants