Update README #1308
Merged
Update README #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
None.
What problem does this PR solve?
The version of Electron specified in the README was out of date. I also added a comment in regard to waiting for Electron to fully start. When I initially cloned this repo and tried to run
yarn devI assumed the branch was broken as I received a number of errors/warnings in my terminal. If you give it some time it loads up fine. Those errors should be addressed or suppressed in a future PR.Is there anything else we should know?
This targets the
devbranch, but will need to be merged intomasteras well.