Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix-version-check #1307

Merged
merged 2 commits into from
Jul 9, 2018
Merged

Conversation

comountainclimber
Copy link
Member

Please see #1299

@coveralls
Copy link

coveralls commented Jul 9, 2018

Coverage Status

Coverage decreased (-0.1%) to 36.133% when pulling 9fb140f on feature/v2-fix-version-check into b542086 on design-v2.


await checkVersion()(dispatch, getState)
expect(spy).not.toHaveBeenCalled()
done()
})

test("it shows a warning when the versions don't match", async done => {
test('it shows a warning when the versions dont match', async done => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo - should be don't

@comountainclimber
Copy link
Member Author

@evgenyboxer prettier hated the escape syntax so added ignore

@comountainclimber comountainclimber merged commit c7713ae into design-v2 Jul 9, 2018
@comountainclimber comountainclimber deleted the feature/v2-fix-version-check branch August 19, 2018 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants