Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable "Scan QR Code" button if camera is not available while logging in with private key #1318

Closed
drptbl opened this issue Jul 10, 2018 · 4 comments
Closed

Disable "Scan QR Code" button if camera is not available while logging in with private key #1318

drptbl opened this issue Jul 10, 2018 · 4 comments
Labels
Bug Something isn't working

Comments

@drptbl
Copy link

drptbl commented Jul 10, 2018 •
edited
Loading

Wallet version or commit SHA:
dev branch (ae58feb)

Environment:
Win 10 Home (64 bit) Version 1803 Build 17134.112

Pre-requisites:
No camera available (VM for example)

Reproduction steps:

  1. Start Neon Wallet
  2. Click on "Login with private key" button

If there is no camera available when going to "Login with private key" page, "Scan QR Code" button should be disabled. Currently if button is clicked, there's an error thrown in console however it's not visible in the wallet UI, so users are not informed about this. Also button changes to "Cancel" - it shouldn't happen in case of error.

If it's not possible to check camera and disable this button, we should at least show the error after clicking on it.

Screenshot/Video:
show_error
@drptbl drptbl added the Bug Something isn't working label Jul 10, 2018
@drptbl drptbl changed the title Show an error if camera is not available while trying to "Scan QR Code" when logging in with private key Disable "Scan QR Code" button if camera is not available while logging in with private key Jul 10, 2018
@ranbena
Copy link
Contributor

ranbena commented Nov 25, 2018

I'll take this

ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 27, 2018
@ranbena
[CityOfZion#1318] Commit 1/2: Enable “Scan QR” button only if camera …
dec8d41 
…available
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 27, 2018
@ranbena
[CityOfZion#1318] Commit 2/2: Test camera availability feature
7c4faf1
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] PrepWork 1: Added util/poll.js unit tests
8634a36
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] PrepWork 1/2: Added util/poll.js unit tests
0ffde19
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] PrepWork 1/3: Added util/poll.js unit tests
fbb94d2
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] PrepWork 2/3: Made util/poll.js cancellable with ca…
4333ac0 
…ncellablePoll
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] PrepWork 3/3: Added cancellablePoll unit tests
117ad1e
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] Actual 1/2: Enable “Scan QR” button only if camera …
9dfcf47 
…available
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] Actual 2/2: Added camera availability unit tests
e2bfcb7
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] PrepWork 1/3: Added util/poll.js unit tests
82e92a0
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] PrepWork 1/3: Added util/poll.js unit tests
4c48aee
@ranbena ranbena mentioned this issue Nov 28, 2018
Merged
1 task
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] PrepWork 2/3: Made util/poll.js cancellable with ca…
e003e68 
…ncellablePoll
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] PrepWork 3/3: Added cancellablePoll unit tests
57ddc3d
@ranbena ranbena mentioned this issue Nov 28, 2018
Merged
1 task
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] Actual 1/2: Enable “Scan QR” button only if camera …
4ffa776 
…available
@ranbena ranbena mentioned this issue Nov 28, 2018
Merged
ranbena added a commit to ranbena/neon-wallet that referenced this issue Nov 28, 2018
@ranbena
[CityOfZion#1318] Actual 2/2: Added camera availability unit tests
6ad3fa3
@ranbena ranbena mentioned this issue Nov 28, 2018
Merged
comountainclimber added a commit that referenced this issue Nov 29, 2018
@comountainclimber
Merge pull request #1730 from ranbena/poll-test
ea2cb54 
[#1318] PrepWork 1/3: Added util/poll.js unit tests
comountainclimber added a commit that referenced this issue Nov 29, 2018
@comountainclimber
Merge pull request #1731 from ranbena/cancellable
e7d72b4 
[#1318] PrepWork 2+3/3: Added cancellable ability to util/poll.js
comountainclimber added a commit that referenced this issue Nov 29, 2018
@comountainclimber
Merge pull request #1732 from ranbena/camera-avail
f56e7ae 
[#1318] Actual 1/2: Enable “Scan QR” button only if camera available
comountainclimber added a commit that referenced this issue Nov 29, 2018
@comountainclimber
Merge pull request #1733 from ranbena/camera-avail-tests
0aeb8d8 
[#1318] Actual 2/2: Added camera availability unit tests
@tbeck860
Copy link

Fix tested successfully on Windows 10 Pro v1803 Build 17134.523
1-15-2019 5-18-13 pm

@comountainclimber
Copy link
Member

Please award @tbeck860 100 🚀

@lllwvlvwlll
Copy link
Member

https://neoscan.io/transaction/220a87f0e9cedf43f05278182794d9c5f49ad6f144e9ebc7fb7aa4b5994c68d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ranbena @drptbl @comountainclimber @lllwvlvwlll @tbeck860