Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

update requirements for doc creation #544

Merged
merged 2 commits into from
Aug 21, 2018
Merged

update requirements for doc creation #544

merged 2 commits into from
Aug 21, 2018

Conversation

ixje
Copy link
Member

@ixje ixje commented Aug 10, 2018

What current issue(s) does this address, or what feature is it adding?
the requirements for just creating documentation were heavily outdated.

How did you solve this problem?
created a fresh install/venv, make doc'ed + pip install until all missing packages were resolved.

How did you make sure your solution works?
make doc
Are there any special changes in the code that we should be aware of?
no
Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@localhuman
Copy link
Collaborator

Last time I checked, the Read the Docs server that builds the docs can only be done with Python 3.5, so I know upgrading neo-boa ( which won't work with 3.5 ) will break the docs server build.

@ixje
Copy link
Member Author

ixje commented Aug 10, 2018

Oh didn't know that. I only tested locally. Any way to test without pushing here?
I think there's a good chance python 3.6 is now supported, see:

@localhuman
Copy link
Collaborator

That would be great if they're supporting 3.6 venv now! I can switch the build to the development branch to see if it works after merging this-

@ixje
Copy link
Member Author

ixje commented Aug 10, 2018

I'll leave it up to you to take further then 👍

@localhuman localhuman merged commit c899160 into CityOfZion:development Aug 21, 2018
@ixje ixje deleted the refresh_doc_requirements branch September 5, 2018 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants