Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Feature storage iterator #406

Merged
merged 21 commits into from
Apr 30, 2018
Merged

Feature storage iterator #406

merged 21 commits into from
Apr 30, 2018

Conversation

localhuman
Copy link
Collaborator

What current issue(s) does this address, or what feature is it adding?

How did you solve this problem?

  • @ixje implemented the storage iterator, and a new release of neo-boa implements the Storage.Find

How did you make sure your solution works?

  • added tests

Are there any special changes in the code that we should be aware of?

  • Yes. Because the mechanism for how items are stored has changed, this is a breaking change that requires a full resync or a re-bootstrap. Or, more generally, this is a schema change of the database.

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

ixje and others added 20 commits March 18, 2018 13:16
 into sc_storage_iterator

* 'sc_storage_iterator' of https://github.com/ixje/neo-python: (42 commits)
  Fixed wrong privnet instructions
  Support pip version 10.0 and greater (#389)
  setup.py: fix shebang: python3
  removing all occurrences of: "# -*- coding:utf-8 -*-" (#386)
  lint fix for comments
  Modified NEP-5 token import test to also test token deletion
  Updated CHANGELOG.rst
  fix for NEP-5 token deletion from wallet
  update changelog
  update logging
  Update CHANGELOG.rst
  create SmartContractEvent with working block height instead of last
  persist NotifyType.REFUND events in notification DB
  remove print
  updated networking
  Bump version: 0.6.7 → 0.6.8-dev
  Bump version: 0.6.7-dev → 0.6.7
  Update changelog for release
  Added CHANGELOG entry
  Added CORS header Access-Control-Allow-Headers
  ...
@localhuman localhuman requested a review from ixje April 30, 2018 15:08
@coveralls
Copy link

coveralls commented Apr 30, 2018

Coverage Status

Coverage decreased (-0.9%) to 78.512% when pulling d7db2fb on feature-storage-iterator into cffe649 on development.

@localhuman localhuman merged commit 0ec3efe into development Apr 30, 2018
@localhuman localhuman deleted the feature-storage-iterator branch June 16, 2018 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants