Clarify and fix event state model #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a number of inconsistencies in the state diagram and adding a graphical representation. Also, adding event_reason to separate the more granual event designators.
hunterowens
reviewed
Mar 4, 2019
hunterowens
reviewed
Mar 4, 2019
hunterowens
reviewed
Mar 4, 2019
Consistency with Provider API
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a number of event/state flow transitions to incorporate initial feedback received from providers. Adding
event_reasonfield to capture more granular event designations and add theannotationfor missing vehicles. Adding a visual diagram to better describe the expected transitions.